Corrects issue corresponding to exchanging format#1
Corrects issue corresponding to exchanging format#1stevejcl wants to merge 10 commits intoDwarfTelescopeUsers:mainfrom
Conversation
src/astro.js
Outdated
|
|
||
| /** | ||
| * 4.1.1 UTC+0 time | ||
| * 4.1.0 UTC+0 time |
There was a problem hiding this comment.
For this library, the numbers for the function should be the same numbers used in the Dwarf API docs, so people can quickly cross reference code in this library with the code in Dwarf API.
Which version of the Dwarf API Docs are you using? I used v1.0, and setting UTC is 4.1.1. There is no setting timezone.
There was a problem hiding this comment.
Yes it's the same, but this function is not documented, (see the request on the fly) so add a number not used maybe need to add : not documented
There was a problem hiding this comment.
Add not documented is a good idea.
package.json
Outdated
| }, | ||
| "type": "module", | ||
| "author": "wykhuh", | ||
| "author": "stevejcl", |
There was a problem hiding this comment.
Use wykhuh and stevejcl as the author.
package.json
Outdated
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/DwarfTelescopeUsers/dwarfii_api" | ||
| "url": "https://github.com/stevejcl/dwarfii_api" |
There was a problem hiding this comment.
Change the repo url back to DwarfTelescopeUsers
| * @returns {string} | ||
| */ | ||
| export const timeZoneURL = (IP) => `http://${IP}:8092/timezone?timezone=`; | ||
|
|
There was a problem hiding this comment.
Which version of the Dwarf API docs are you using? I did not see setting timezone mentioned in the 1.0 API docs. https://hj433clxpv.feishu.cn/docx/MiRidJmKOobM2SxZRVGcPCVknQg
There was a problem hiding this comment.
this function is not documented, (see the request on the fly by using wireshark.
| // goto | ||
| export const calibrateGotoCmd = 11205; | ||
| export const startGotoCmd = 11203; | ||
| export const stopGotoCmd = 11204; |
There was a problem hiding this comment.
Cool that you added stop goto. How did you get the code for stopGoto? I didn't see it in the 1.0 API docs.
There was a problem hiding this comment.
see the request on the fly by using wireshark
| // can't get it working ! | ||
| return `${timeZoneURL(IP)}${timezone}`; | ||
| } | ||
|
|
There was a problem hiding this comment.
If this code doesn't work, then don't merge it into main.
There was a problem hiding this comment.
Sorry it's ok , now forget to remove the comment ..
There was a problem hiding this comment.
Made this correction on 0.0.2-beta.4
2 participants
After analysing web socket trames send and received by the mobile APP, I change the exchange format of data for RA and declination. Add also a trame for exchanging timezone.
Add a api for StopGoto.
Correction for Goto to Planet : need Ra and declination value to be present and egals to 0.